perf: Replace getById call with getFistNodeByid#1743
Merged
Conversation
CarlSchwan
requested review from
JuliaKirschenheuter and
enjeck
as code owners
artonge
approved these changes
Feb 5, 2026
artonge
left a comment
artonge
left a comment
There was a problem hiding this comment.
Is it also an issue on user folders?
In any case, it simplifies the code, so let's go!
Member
Author
|
getFirstNodeById is not available with NC28 :/ I wonder why this app still support 28, it's EOL since a while |
Contributor
i don't mind updating for the next release |
We only need the first node anyway and getFirstNodeById is quite a bit faster in many cases. Signed-off-by: Carl Schwan <carlschwan@kde.org>
enjeck
force-pushed
the
carl/perf-getbyid
branch
from
a65e280 to
f78ba12
Compare
enjeck
force-pushed
the
carl/perf-getbyid
branch
2 times, most recently
from
9072121 to
129078c
Compare
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
enjeck
force-pushed
the
carl/perf-getbyid
branch
from
129078c to
3928986
Compare
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
enjeck
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We only need the first node anyway and getFirstNodeById is quite a bit faster in many cases.